Skip to content

Please format all report values to use ',' for thousands separator to make reading large values easier #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
clint-qrypt opened this issue Dec 30, 2024 · 10 comments
Open
2 tasks done

Please format all report values to use ',' for thousands separator to make reading large values easier #3017

clint-qrypt opened this issue Dec 30, 2024 · 10 comments
Labels
feature request

Comments

@clint-qrypt
Copy link

Prerequisites

Description

Long running Locust.io load tests produce extremely large values. Please format the values displayed in the reports with correct formatting with commas in the thousands separator. Update both the terminal summary an the webUI reports. Any value that is displayed to a user would make reading the reports much easier.
@OriShalhon
Copy link

is this still relevant ?
I can implement it

@clint-qrypt
Copy link
Author

clint-qrypt commented Mar 3, 2025 via email

@OriShalhon
Copy link

Great, I am not familiar with this repository but it seems like a great way to familiarize myself with it , I will work on implementing it on my free time and will send here updates regarding how it looks .

@clint-qrypt
Copy link
Author

clint-qrypt commented Mar 10, 2025 via email

@domik82
Copy link

domik82 commented Apr 26, 2025

I'm not exactly sure if I correctly understand this - we are talking about for example, 'count' of iterations so a number like 958463215

You know guys that in Europe we use ',' also for decimal separator and some people are used to it. So 10,598 for me would mean 10.598 - for "count" that doesn't make sense and it could cause confusion.

I'm not really convinced by that change at all. This also might break plenty of CSV formatters.

If this were to be implemented, the best would be to use more neutral space as a separator, so the large number would become 958 463 215 - still, the same thing, remember about CSV formatting.

@cyberw what do you think about it?

@cgoldberg
Copy link
Member

I would suggest following Python standards and using underscore as separator: 958_463_215

https://peps.python.org/pep-0515/

@domik82
Copy link

domik82 commented Apr 26, 2025 •
edited
Loading

Where? On web page showing stats and command line output? That doesn't make any sense to me.

If such feature would be implemented it shouldn't be python related at all - look at Gatling, k6, JMeter.

Just because tool is written in Python it doesn't determine that stats shown in UI should follow some pep standard.

@clint-qrypt
Copy link
Author

clint-qrypt commented Apr 28, 2025 via email

@domik82
Copy link

domik82 commented Apr 28, 2025

You know that often people in Europe work for US companies so the nodes might configured by default with US locale, so it's really not that simple as using local.

I would honestly look at it as optional feature and leave current formatting as default one. Then you could change it by additional parameter passed during execution.

@clint-qrypt
Copy link
Author

clint-qrypt commented Apr 28, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cgoldberg @domik82 @OriShalhon @clint-qrypt